Skip to content

perf: Replace getById call with getFirstNodeById#2360

Merged
CarlSchwan merged 2 commits into
masterfrom
carl/perf-getbyid
Feb 19, 2026
Merged

perf: Replace getById call with getFirstNodeById#2360
CarlSchwan merged 2 commits into
masterfrom
carl/perf-getbyid

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented Feb 5, 2026

Copy link
Copy Markdown
Member

And some other minor cleanup in ViewInfoCache

@CarlSchwan CarlSchwan added this to the Nextcloud 34 milestone Feb 5, 2026
@CarlSchwan CarlSchwan self-assigned this Feb 5, 2026
@nickvergessen
nickvergessen requested review from miaulalala and removed request for nickvergessen February 5, 2026 15:39
@cypress

cypress Bot commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Activity    Run #3339

Run Properties:  status check passed Passed #3339  •  git commit b0ac487485: perf: Replace getById call with getFirstNodeById
Project Activity
Branch Review carl/perf-getbyid
Run status status check passed Passed #3339
Run duration 02m 20s
Commit git commit b0ac487485: perf: Replace getById call with getFirstNodeById
Committer Carl Schwan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 9
View all changes introduced in this branch ↗︎

@miaulalala

miaulalala commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Backport?

@miaulalala

miaulalala commented Feb 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Linter and PHPUnit are not happy:


There were 3 errors:

1) OCA\Activity\Tests\ViewInfoCacheTest::testGetInfoById with data set #0 ('user', 23, 'path', [], true, 'findInfoById')
PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method findInfoById may not return value of type string, its declared return type is "array"

/home/runner/work/activity/activity/apps/activity/tests/ViewInfoCacheTest.php:122

2) OCA\Activity\Tests\ViewInfoCacheTest::testGetInfoById with data set #1 ('user', 23, 'path', [['returnCache']], true, 'findInfoById')
PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method findInfoById may not return value of type string, its declared return type is "array"

/home/runner/work/activity/activity/apps/activity/tests/ViewInfoCacheTest.php:122

3) OCA\Activity\Tests\ViewInfoCacheTest::testGetInfoById with data set #2 ('user', 23, 'path', [['returnCache']], true, 'findInfoById')
PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method findInfoById may not return value of type string, its declared return type is "array"

/home/runner/work/activity/activity/apps/activity/tests/ViewInfoCacheTest.php:122

@CarlSchwan
CarlSchwan enabled auto-merge February 12, 2026 00:39
@CarlSchwan

CarlSchwan commented Feb 12, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@CarlSchwan @miaulalala
perf: Replace getById call with getFirstNodeById
8bdd699 
And some other minor cleanup in ViewInfoCache

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan @miaulalala
chore: bump nextcloud/ocp
bc5de42 
Fix psalm when running locally

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan merged commit f5b60d3 into master Feb 19, 2026
55 checks passed
@CarlSchwan
CarlSchwan deleted the carl/perf-getbyid branch February 19, 2026 15:14
@backportbot backportbot Bot mentioned this pull request Feb 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes
@artonge artonge Awaiting requested review from artonge

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

2 participants

@CarlSchwan @miaulalala